Refactor PathsAndConsumesOfModules #47937

Dr15Jones · 2025-04-23T19:32:12Z

PR description:

moved complex logic for creating the internal data structures to the class itself
can now ask an ESProducer what is produces
provide a mechanism to get minimal information about what ES products are being consumed

PR validation:

Framework unit tests pass.

- moved complex logic for creating the internal data structures to the class itself - can no ask an ESProducer what is produces - provide a mechanism to get minimal information about what ES products are being consumed

cmsbuild · 2025-04-23T19:32:40Z

cms-bot internal usage

cmsbuild · 2025-04-23T19:33:57Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47937/44595

ERROR: Build errors found during clang-tidy run.

  350 |                                module,
--
src/FWCore/Framework/interface/EDConsumerBase.h:349:13: error: invalid use of incomplete type 'ModuleConsumesInfo' [clang-diagnostic-error]
  349 |       iFunc(ModuleConsumesInfo(itInfo->m_type,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  350 |                                module,
--
src/FWCore/Framework/interface/EDConsumerBase.h:349:13: error: invalid use of incomplete type 'ModuleConsumesInfo' [clang-diagnostic-error]
  349 |       iFunc(ModuleConsumesInfo(itInfo->m_type,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  350 |                                module,
--
src/FWCore/Framework/interface/EDConsumerBase.h:349:13: error: invalid use of incomplete type 'ModuleConsumesInfo' [clang-diagnostic-error]
  349 |       iFunc(ModuleConsumesInfo(itInfo->m_type,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  350 |                                module,
--
src/FWCore/Framework/interface/EDConsumerBase.h:349:13: error: invalid use of incomplete type 'ModuleConsumesInfo' [clang-diagnostic-error]
  349 |       iFunc(ModuleConsumesInfo(itInfo->m_type,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  350 |                                module,
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2025-04-23T19:49:08Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47937/44596

There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/CondHDF5ESSource/plugins/CondHDF5ESSource.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/ESTestProducers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/TestESConcurrentSource.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/TestESSource.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47937/44596/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47937/44596/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47937/44596/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47937/44596/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2025-04-23T20:03:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47937/44597

There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/CondHDF5ESSource/plugins/CondHDF5ESSource.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/ESTestProducers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/TestESConcurrentSource.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/TestESSource.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2025-04-23T20:03:33Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

CondCore/CondHDF5ESSource (db)
CondCore/ESSources (db, alca)
FWCore/Framework (core)
FWCore/Integration (core)
FWCore/Services (core)
FWCore/TestProcessor (core)
PhysicsTools/CondLiteIO (analysis)

@Dr15Jones, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @makortel, @perrotta, @smuzaffar, @tvami can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @fwyzard, @makortel, @missirol, @mmusich, @rsreds, @tocheng, @wddgit, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2025-04-23T20:04:08Z

please test

cmsbuild · 2025-04-26T12:56:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47937/44624

There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/CondHDF5ESSource/plugins/CondHDF5ESSource.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/ESTestProducers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/TestESConcurrentSource.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File FWCore/Integration/plugins/TestESSource.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2025-04-26T12:57:07Z

Pull request #47937 was updated. @Dr15Jones, @atpathak, @cmsbuild, @consuegs, @francescobrivio, @makortel, @perrotta, @smuzaffar, @tvami can you please check and sign again.

Dr15Jones · 2025-04-26T12:58:38Z

please test

cmsbuild · 2025-04-26T17:03:35Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40a674/45727/summary.html
COMMIT: cbe57e9
CMSSW: CMSSW_15_1_X_2025-04-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47937/45727/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_MilleZmm had ERRORS

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3913297
DQMHistoTests: Total failures: 52
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3913225
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

Dr15Jones · 2025-04-28T16:05:16Z

The failing unit test is failing in the IB so has nothing to do with this PR.

makortel · 2025-04-28T20:34:51Z

+core

makortel · 2025-04-28T20:35:13Z

Comparison differences are related to #47071

makortel · 2025-04-28T20:35:33Z

ignore tests-rejected with ib-failure

tvami · 2025-04-29T01:43:24Z

+1

Dr15Jones added 2 commits April 23, 2025 14:29

Refactor consumes info for PathsAndConsumesOfModules

d834701

- moved complex logic for creating the internal data structures to the class itself - can no ask an ESProducer what is produces - provide a mechanism to get minimal information about what ES products are being consumed

Updated to new ProductResolverProvider interface

bcf17d7

cmsbuild added this to the CMSSW_15_1_X milestone Apr 23, 2025

cmsbuild added core-pending analysis-pending alca-pending db-pending pending-signatures tests-pending orp-pending code-checks-pending labels Apr 23, 2025

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Apr 23, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 23, 2025

clang-tidy changes

f1d9dc9

Dr15Jones force-pushed the refactorPathsAndConsumesOfModules branch from 632df35 to f1d9dc9 Compare April 23, 2025 20:00

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 23, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 23, 2025

cmsbuild removed the tests-pending label Apr 23, 2025

cmsbuild added the tests-approved label Apr 24, 2025

Improvements based on review feedback

cbe57e9

Dr15Jones force-pushed the refactorPathsAndConsumesOfModules branch from fd2c767 to cbe57e9 Compare April 26, 2025 12:55

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Apr 26, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 26, 2025

cmsbuild added tests-started and removed tests-pending labels Apr 26, 2025

cmsbuild added tests-rejected and removed tests-started labels Apr 26, 2025

cmsbuild added core-approved and removed core-pending labels Apr 28, 2025

cmsbuild added tests-approved tests-ib-failure and removed tests-rejected labels Apr 28, 2025

makortel mentioned this pull request Apr 28, 2025

Extend tests for PathsAndConsumesOfModules cms-sw/framework-team#1371

Open

cmsbuild added analysis-approved and removed analysis-pending labels Apr 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor PathsAndConsumesOfModules #47937

Refactor PathsAndConsumesOfModules #47937

Dr15Jones commented Apr 23, 2025 •

edited

Loading

cmsbuild commented Apr 23, 2025 •

edited

Loading

cmsbuild commented Apr 23, 2025

cmsbuild commented Apr 23, 2025

cmsbuild commented Apr 23, 2025

cmsbuild commented Apr 23, 2025

Dr15Jones commented Apr 23, 2025

cmsbuild commented Apr 26, 2025

cmsbuild commented Apr 26, 2025

Dr15Jones commented Apr 26, 2025

cmsbuild commented Apr 26, 2025

Dr15Jones commented Apr 28, 2025

makortel commented Apr 28, 2025

makortel commented Apr 28, 2025

makortel commented Apr 28, 2025

tvami commented Apr 29, 2025

Refactor PathsAndConsumesOfModules #47937

Are you sure you want to change the base?

Refactor PathsAndConsumesOfModules #47937

Conversation

Dr15Jones commented Apr 23, 2025 • edited Loading

PR description:

PR validation:

cmsbuild commented Apr 23, 2025 • edited Loading

cmsbuild commented Apr 23, 2025

cmsbuild commented Apr 23, 2025

cmsbuild commented Apr 23, 2025

cmsbuild commented Apr 23, 2025

Dr15Jones commented Apr 23, 2025

cmsbuild commented Apr 26, 2025

cmsbuild commented Apr 26, 2025

Dr15Jones commented Apr 26, 2025

cmsbuild commented Apr 26, 2025

Unit Tests

Comparison Summary

Dr15Jones commented Apr 28, 2025

makortel commented Apr 28, 2025

makortel commented Apr 28, 2025

makortel commented Apr 28, 2025

tvami commented Apr 29, 2025

Dr15Jones commented Apr 23, 2025 •

edited

Loading

cmsbuild commented Apr 23, 2025 •

edited

Loading